Add CLIENT INFO command as Redis #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add CLIENT INFO command as Redis, this command returns information about the current client connection, the output format is the same as CLIENT LIST command. CLIENT INFO was added in Redis 6.2.0
enjoy-binbin
commented
Mar 25, 2023
| @@ -45,6 +45,11 @@ func TestIntrospection(t *testing.T) { | |||
| require.Regexp(t, "id=.* addr=.*:.* fd=.* name=.* age=.* idle=.* flags=N namespace=.* qbuf=.* .*obuf=.* cmd=client.*", v) | |||
| }) | |||
|
|
|||
| t.Run("CLIENT INFO", func(t *testing.T) { | |||
| v := rdb.Do(ctx, "CLIENT", "INFO").Val() | |||
There was a problem hiding this comment.
note go-redis does not support CLIENT INFO yet (a pending PR, should be supported soon)
so here i am using Do
|
Cool, Thanks for your contribution. @enjoy-binbin We can use the command |
torwig
reviewed
Mar 25, 2023
There was a problem hiding this comment.
LGTM. @enjoy-binbin just run the command @git-hulk provided and commit changes.
torwig
approved these changes
Mar 25, 2023
|
Thanks all, merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add CLIENT INFO command as Redis, this command
returns information about the current client connection,
the output format is the same as CLIENT LIST command.
CLIENT INFO was added in Redis 6.2.0