Rewrite encoding functions #1358

PragmaTwice · 2023-03-27T13:36:36Z

We use if constexpr, __builtin_bswapN and __builtin_memcpy for better performance and maintainability.

git-hulk

Cool, LGTM.

I saw the clang replace the memcpy with __builtin_memcpy in the underlying implementation but didn't check the GCC.

__DEVICE__ void *memcpy(void *__a, const void *__b, size_t __c) {
  return __builtin_memcpy(__a, __b, __c);
}

torwig · 2023-03-27T15:10:37Z

src/common/encoding.cc

+
+  __builtin_memcpy(&value, ptr, sizeof(value));
+
+  return BYTE_ORDER == LITTLE_ENDIAN ? __builtin_bswap32(value) : value;


@PragmaTwice Is there a possibility to use if constexpr here with the condition? Or it wouldn't change anything?

Yes, if constexpr is just a constraint in this case. Compiler will eliminate constant conditions.

Rewrite encoding functions

dca4082

PragmaTwice requested review from git-hulk and torwig March 27, 2023 13:36

Merge branch 'unstable' into encoding

7961273

git-hulk approved these changes Mar 27, 2023

View reviewed changes

torwig reviewed Mar 27, 2023

View reviewed changes

PragmaTwice merged commit 3f86bec into apache:unstable Mar 27, 2023

Provide feedback


		__builtin_memcpy(&value, ptr, sizeof(value));

		return BYTE_ORDER == LITTLE_ENDIAN ? __builtin_bswap32(value) : value;