Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable readability-identifier-naming in clang-tidy #1383

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

PragmaTwice
Copy link
Member

We enable readability-identifier-naming in clang-tidy to check naming convension.

Rules:

  - key:           readability-identifier-naming.LocalVariableCase
    value:         lower_case
  - key:           readability-identifier-naming.StructCase
    value:         CamelCase
  - key:           readability-identifier-naming.ClassCase
    value:         CamelCase
  - key:           readability-identifier-naming.UnionCase
    value:         CamelCase
  - key:           readability-identifier-naming.ParameterCase
    value:         lower_case
  # FIXME: enable these options
  # - key:           readability-identifier-naming.PublicMethodCase
  #   value:         CamelCase
  # - key:           readability-identifier-naming.PrivateMethodCase
  #   value:         camelBack
  # - key:           readability-identifier-naming.ProtectedMethodCase
  #   value:         camelBack
  - key:           readability-identifier-naming.LocalConstantCase
    value:         aNy_CasE  # FIXME: use a more strictly case
  - key:           readability-identifier-naming.ClassMemberCase
    value:         lower_case
  - key:           readability-identifier-naming.ClassMemberSuffix
    value:         _
  - key:           readability-identifier-naming.ClassConstantCase
    value:         aNy_CasE  # FIXME: use a more strictly case

@PragmaTwice PragmaTwice requested a review from git-hulk April 13, 2023 09:39
git-hulk
git-hulk previously approved these changes Apr 13, 2023
torwig
torwig previously approved these changes Apr 13, 2023
@PragmaTwice PragmaTwice dismissed stale reviews from torwig and git-hulk via 1714a93 April 13, 2023 12:59
@PragmaTwice PragmaTwice requested review from git-hulk and torwig April 13, 2023 13:01
torwig
torwig previously approved these changes Apr 13, 2023
@PragmaTwice PragmaTwice merged commit 0f7f0b2 into apache:unstable Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants