Fix missing to set the cluster node id when loading #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
previously approved these changes
Apr 13, 2023
We supported loading the cluster nodes from the local file, but ignore the cluster node id after parsing. So it can't match the cluster node since the local node id is empty, then it will fallback to check if the listen IP and port is matched.
PragmaTwice
approved these changes
Apr 14, 2023
torwig
approved these changes
Apr 14, 2023
|
Thanks all, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we supported loading the cluster nodes from the local file, but we just ignored the cluster node id after parsing. So it can't match the cluster node since the local node id is empty, and it will fall back to check if the listening IP and port are matched.
For example, we create a cluster with a single node and listen on 0.0.0.0, then we would get the below output after restarting:
$ 127.0.0.1:6666> cluster nodes 3dQzcqeiTpSqPstxtD1utGuU52fPkGnoIHPO8KgL 127.0.0.1:6666@16666 master - 1681396166414 1681396166415 0 connected 0-16383it missed a
myselffield because didn't use the node id from the local file, then it will fall back to IP/Port, but the listening IP 0.0.0.0 is unmatched with 127.0.0.1, this issue was submitted in #1381.After this PR, we can get the correct result:
$ 127.0.0.1:6666> cluster nodes 3dQzcqeiTpSqPstxtD1utGuU52fPkGnoIHPO8KgL 127.0.0.1:6666@16666 myself,master - 1681396232426 1681396232427 0 connected 0-16383