Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check method and namespace names in readability-identifier-naming #1388

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Check method and namespace names in readability-identifier-naming #1388

merged 1 commit into from
Apr 14, 2023

Conversation

PragmaTwice
Copy link
Member

public methods: CamelCase
private/protected methods: camelBack
namespace: lower_case

@PragmaTwice PragmaTwice requested a review from git-hulk April 14, 2023 07:14
torwig
torwig approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @PragmaTwice!

@PragmaTwice
Copy link
Member Author

Thanks all. Merging...

@PragmaTwice PragmaTwice merged commit 7be2af3 into apache:unstable Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @torwig