Add TIME command as Redis #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the TIME command. The TIME command returns the current server time as a two items lists: a Unix timestamp and the amount of microseconds already elapsed in the current second. Example: ``` 127.0.0.1:6666> time 1) "1681828105" 2) "810037" ``` This closes apache#1393
|
having trouble with how to add a time test case... |
enjoy-binbin
force-pushed
the
time_command
branch
from
8f56fe6 to
7f27843
Compare
@enjoy-binbin Do you mean that you don't know how to check if the time command is correct? If yes, we can only check if the seconds field is in the range of [now-2, now+2] by using And if you don't know where to add the test case, can just imitate the ping command test case. |
torwig
reviewed
Apr 18, 2023
|
@git-hulk thanks. i got it now |
torwig
reviewed
Apr 18, 2023
git-hulk
reviewed
Apr 19, 2023
Co-authored-by: hulk <hulk.website@gmail.com>
git-hulk
reviewed
Apr 19, 2023
git-hulk
approved these changes
Apr 19, 2023
|
Thanks all, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the TIME command. The TIME command returns the current
server time as a two items lists: a Unix timestamp and the amount of
microseconds already elapsed in the current second.
Example:
This closes #1393