Add the ability to use the '*-123' pattern to specify stream entry ID via XADD #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… via XADD It allows Kvrocks server to set current timestamp as the first part of the entry ID and provided by the client sequence number as the second part of it.
|
Awesome feature, we are waiting for this, lot of thanks! For example, we can use this streamID for checking latency for each message (if consumer after processing, store an result with a same ID, but new autogenerated part of time). |
|
And some of futures - this feature will be pretty use with XMOVE/XCOPY next command planned too... ;) |
PragmaTwice
changed the title
git-hulk
approved these changes
Apr 29, 2023
|
Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Redis Stream has 3 strategies to form the new entry's ID (provided with the XADD command):
*pattern12345-6789pattern12345-*pattern.This PR introduces an additional pattern
*-12345when a client is able to specify a sequence number and a timestamp will be generated by the Kvrocks server.The new pattern allows clients to use their internal IDs as part of an entry ID.
Kvrocks generates timestamps and order incoming entries by the receiving time.