Allow default username and fix case sensitive check in HELLO #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
previously approved these changes
Apr 28, 2023
torwig
previously approved these changes
Apr 28, 2023
tisonkun
previously approved these changes
Apr 29, 2023
src/commands/cmd_server.cc
Outdated
| @@ -657,7 +657,7 @@ class CommandTime : public Commander { | |||
| } | |||
| }; | |||
|
|
|||
| /* HELLO [<protocol-version> [AUTH <password>] [SETNAME <name>] ] */ | |||
| /* HELLO [<protocol-version> [AUTH [<password>|<username> <password>]] [SETNAME <name>] ] */ | |||
There was a problem hiding this comment.
Perhaps add a comment that username should be always default otherwise it fails. And such syntax is for compatible only.
…check with HELLO options Signed-off-by: Rueian <rueiancsie@gmail.com>
rueian
dismissed stale reviews from tisonkun, torwig, and PragmaTwice
via
d1d6507
rueian
force-pushed
the
hello-auth-with-username
branch
from
0399a1f to
d1d6507
Compare
tisonkun
approved these changes
Apr 29, 2023
2 tasks
PragmaTwice
changed the title
|
Merging. Thanks for your contribution. |
|
Seems that only "hello" support authenticate with user, should https://redis.io/commands/auth/ support that? |
I think it is not urgent as HELLO, since HELLO in redis just does not allow the username to be omitted, but |
|
Ok, reasonable. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, following the conversation #1403
This PR makes the
HELLOcommand:defaultusername as well.AUTHandSETNAME. Clients may send these options in lower or upper cases. For example, go-redis sends them in lower cases.I think this PR won't break any existing Kvrocks clients but will remove barriers for other clients to adapt Kvrocks by aligning HELLO syntax with Redis.
Please let me know if these changes make sense.