Rename internal macro ENABLE_NEW_ENCODING to METADATA_ENCODING_VERSION #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems ok, RocksDB also use way like that https://rocksdb.org/blog/2019/03/08/format-version-4.html |
Done. |
PragmaTwice
changed the title
mapleFU
approved these changes
Apr 29, 2023
torwig
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the document,
KVROCKS_ENCODING_VERSIONseems to be a more scalable name thanENABLE_NEW_ENCODING, since the NEW encoding can become an OLD encoding, but the encoding version can be a definite number.BTW, I move two test file from
cppunit/typestocppunit/, since they are both not related to types.