Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless type cast in redis_slot.cc #1409

Merged
merged 3 commits into from
Apr 29, 2023
Merged

Remove useless type cast in redis_slot.cc #1409

merged 3 commits into from
Apr 29, 2023

Conversation

PragmaTwice
Copy link
Member

Mostly uint64_t and int.

@PragmaTwice PragmaTwice requested a review from git-hulk April 29, 2023 10:18
@mapleFU
Copy link
Member

mapleFU commented Apr 29, 2023

Can we have lint to find that some cast is useless?

@PragmaTwice
Copy link
Member Author

Can we have lint to find that some cast is useless?

Currently no.

@PragmaTwice
Copy link
Member Author

Thanks all. Merging...

@PragmaTwice PragmaTwice merged commit 30e9fd7 into apache:unstable Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PragmaTwice @mapleFU @git-hulk @torwig @tisonkun