Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce UniqueEvent and CallbackBase for more intuitive event handle #1420

Merged
merged 2 commits into from
May 5, 2023
Merged

Introduce UniqueEvent and CallbackBase for more intuitive event handle #1420

merged 2 commits into from
May 5, 2023

Conversation

PragmaTwice
Copy link
Member

  • UniqueEvent, just an instance of unique_ptr
  • EvbufCallbackBase<T, bool, bool, bool> and EventCallbackBase<T>: event callback base class (via CRTP)

@PragmaTwice PragmaTwice requested review from git-hulk and torwig May 5, 2023 08:56
git-hulk
git-hulk previously approved these changes May 5, 2023
View reviewed changes
@PragmaTwice PragmaTwice requested a review from git-hulk May 5, 2023 10:38
@PragmaTwice
Copy link
Member Author

Thanks all. Merging...

@PragmaTwice PragmaTwice merged commit ff715c5 into apache:unstable May 5, 2023
@ellutionist ellutionist mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @torwig