build: migrate go-redis/redis to redis/go-redis #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
previously approved these changes
May 19, 2023
caipengbo
previously approved these changes
May 19, 2023
tisonkun
reviewed
May 19, 2023
torwig
previously approved these changes
May 19, 2023
infdahai
changed the title
|
@tisonkun I modify the issue. |
infdahai
changed the title
infdahai
changed the title
1. Upgrade redis-go to v9.0.4 2. migrate go-redis/redis to redis/go-redis Signed-off-by: clundro <infdahai@outlook.com>
BTW, mabe we can create a template for pull requests and it increases readability for code reviewers, such as risingwave pr_template or clickhouse pr_template(for changelogs). |
You're free to make your suggestion and patch, while I never find a long template help. Patches varies from one another and I tend to trust the author to fill necessary info. Also, the reviewers can give their suggestions. |
tisonkun
changed the title
tisonkun
approved these changes
May 19, 2023
git-hulk
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the go-redis package to support more redis commands and migrate go-redis packages.
What's changed and what's your intention?
And more specifically, I want to use bzpop<max|min|null>, <z|s>intercard, zmpop go APIs to write some go-unit tests for supporting the more commands from
zsetorsetinkvrocks. These commands from redis(version >= 6.2) are not implemented in this project.Due to is redis/go-version is a new version for go-redis/redis redis/go-redis#2560 (comment), we should use
replaceingo.modor change"github.com/go-redis/redis/v9"from import-blocks in go files.The latter is more similar to contribsys/faktory@4454c4a and I prefer to try this based on Used for two different module paths error in go mod tidy golang-jwt/jwt#37 (comment).