Fix crash when hitting the perflog command rule #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cause is that we didn't allow the entry when creating the unique ptr. So it will be a null pointer when the command was hitting the perflog rule.
|
Good catch! My bad. |
torwig
approved these changes
Jun 1, 2023
|
@git-hulk Thanks for reproducing and adding the appropriate test. |
PragmaTwice
approved these changes
Jun 1, 2023
No problem. I also didn't catch this when reviewing. The main issue is that we didn't have any test cases for this command. |
git-hulk
changed the title
|
Thanks all, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause is that we didn't allow the entry when creating
the unique ptr. So it will be a null pointer when the command
was hitting the perflog rule.
This closes #1480