Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): Bump rocksdb v8.3.2 #1516

Merged
merged 5 commits into from
Jun 25, 2023
Merged

build(deps): Bump rocksdb v8.3.2 #1516

merged 5 commits into from
Jun 25, 2023

Conversation

aleksraiden
Copy link
Contributor

Bump Rocksdb v8.3.2

In this release:

  • (perf) Improved the I/O efficiency of prefetching SST metadata by recording more information in the DB manifest
  • (perf) CPU features are no longer detected at runtime nor in build scripts, but in source code using common preprocessor defines
  • (bug) Delete an empty WAL file on DB open
  • (bug) Delete temp OPTIONS file on DB open
  • (bug) Fixed higher read QPS during DB::Open()
  • (bug) Reduced cases of illegally using Env::Default()
  • (feat) New statistics tickers
  • (feat) Add new API DB::ClipColumnFamily to clip the key in CF to a certain range. It will physically deletes all keys outside the range including tombstones.
  • (feat) Add MakeSharedCache() construction functions to various cache Options objects
  • (feat) Changed the meaning of various Bloom filter stats

Full release doc: https://github.com/facebook/rocksdb/releases/tag/v8.3.2

@aleksraiden
Update rocksdb.cmake
0036308 
Bump Rocksdb v8.3.2
@aleksraiden aleksraiden marked this pull request as draft June 24, 2023 10:15
@aleksraiden
Update CMakeLists.txt
0759499 
Change PORTABLE options into 0 instead of OFF (see: facebook/rocksdb#11419)
@aleksraiden
Update x.py
1ba4fae 
Nedd to default PERTABLE set to 0 for default cpu set supporting
@aleksraiden
Update Dockerfile
3a55e37 
Fix Dockerfile
@aleksraiden
Copy link
Contributor Author

In this version of rocksdb changes a compiler flag PORTABLE, so I changes it into Cmake and Docker for default value 0. In this case all of features (related to CPU) are in runtime.

So, now PORTABLE option must be:

  • 0 and compiler work as best as it can
  • 1 usually nothing to do; compiler default is typically the most general
  • and we can set a CPU family for build best optimal code, e.g.: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake-client rocketlake icelake-server cascadelake tigerlake cooperlake sapphirerapids alderlake bonnell atom silvermont slm goldmont goldmont-plus tremont knl knm x86-64 x86-64-v2 x86-64-v3 x86-64-v4 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 znver2 znver3 btver1 btver2 native

Detailed, we can see in this code diff: facebook/rocksdb@5cb6251

@aleksraiden aleksraiden marked this pull request as ready for review June 24, 2023 12:20
git-hulk
git-hulk reviewed Jun 25, 2023
View reviewed changes
x.py Show resolved Hide resolved
torwig
torwig approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@git-hulk I also had that question about the PORTABLE flag 👍

tisonkun
tisonkun approved these changes Jun 25, 2023
View reviewed changes
x.py Show resolved Hide resolved
@tisonkun
Copy link
Member

Merging...

Thank you!

@tisonkun tisonkun merged commit 2305490 into apache:unstable Jun 25, 2023
@tisonkun tisonkun changed the title (deps) Bump rocksdb v8.3.2 build(deps): Bump rocksdb v8.3.2 Jun 25, 2023
@git-hulk git-hulk mentioned this pull request Jul 5, 2023
Merged
@git-hulk git-hulk mentioned this pull request Jul 19, 2023
Closed
2 tasks
git-hulk pushed a commit that referenced this pull request Jul 21, 2023
@ovaistariq
Fix Docker image may crash if running on the AMD platform (#1602)
5de3acc 
RocksDB PORTABLE was set to 0 after #1516 and it may return an illegal instruction error
when running on the AMD platform. This PR fixes this issue by changing the default value
of PORTABLE to 1 so that it can compile the rocksdb without platform special instructions.
git-hulk pushed a commit to git-hulk/kvrocks that referenced this pull request Jul 30, 2023
@ovaistariq @git-hulk
Fix Docker image may crash if running on the AMD platform (apache#1602)
842b68c 
RocksDB PORTABLE was set to 0 after apache#1516 and it may return an illegal instruction error
when running on the AMD platform. This PR fixes this issue by changing the default value
of PORTABLE to 1 so that it can compile the rocksdb without platform special instructions.
git-hulk pushed a commit that referenced this pull request Aug 1, 2023
@ovaistariq @git-hulk
Fix Docker image may crash if running on the AMD platform (#1602)
3fe7b82 
RocksDB PORTABLE was set to 0 after #1516 and it may return an illegal instruction error
when running on the AMD platform. This PR fixes this issue by changing the default value
of PORTABLE to 1 so that it can compile the rocksdb without platform special instructions.
p1u3o pushed a commit to p1u3o/incubator-kvrocks that referenced this pull request Aug 1, 2023
@ovaistariq @p1u3o
Fix Docker image may crash if running on the AMD platform (apache#1602)
3b3a6b2 
RocksDB PORTABLE was set to 0 after apache#1516 and it may return an illegal instruction error
when running on the AMD platform. This PR fixes this issue by changing the default value
of PORTABLE to 1 so that it can compile the rocksdb without platform special instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleksraiden @tisonkun @git-hulk @torwig