Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZUNION arity should be -3 instread of -4 #1589

Merged
merged 2 commits into from
Jul 13, 2023
Merged

ZUNION arity should be -3 instread of -4 #1589

merged 2 commits into from
Jul 13, 2023

Conversation

enjoy-binbin
Copy link
Member

before:

127.0.0.1:6666> zunion 1 zset
(error) ERR wrong number of arguments

after:

127.0.0.1:6666> zunion 1 zset
(empty array)

127.0.0.1:6666> zunion 1 zset
1) "a"
2) "b"
3) "c"

@git-hulk git-hulk merged commit daece9e into apache:unstable Jul 13, 2023
@enjoy-binbin enjoy-binbin deleted the fix_zunion_arity branch July 13, 2023 10:20
git-hulk pushed a commit to git-hulk/kvrocks that referenced this pull request Jul 30, 2023
@enjoy-binbin @git-hulk
ZUNION arity should be -3 instread of -4 (apache#1589)
b41e8d9 
before:
```
127.0.0.1:6666> zunion 1 zset
(error) ERR wrong number of arguments
```

after:
```
127.0.0.1:6666> zunion 1 zset
(empty array)

127.0.0.1:6666> zunion 1 zset
1) "a"
2) "b"
3) "c"
```
@git-hulk git-hulk mentioned this pull request Jul 31, 2023
Merged
git-hulk pushed a commit that referenced this pull request Aug 1, 2023
@enjoy-binbin @git-hulk
ZUNION arity should be -3 instread of -4 (#1589)
d8da86c 
before:
```
127.0.0.1:6666> zunion 1 zset
(error) ERR wrong number of arguments
```

after:
```
127.0.0.1:6666> zunion 1 zset
(empty array)

127.0.0.1:6666> zunion 1 zset
1) "a"
2) "b"
3) "c"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enjoy-binbin @git-hulk @PragmaTwice