Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make config enum error more clear for users #1639

Merged
merged 3 commits into from
Aug 6, 2023
Merged

Make config enum error more clear for users #1639

merged 3 commits into from
Aug 6, 2023

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Aug 6, 2023 •
edited by enjoy-binbin
Loading

  • provide all acceptable enum option values for user while current option value is invalid
  • some cleanups

@PragmaTwice PragmaTwice requested a review from git-hulk August 6, 2023 00:51
@PragmaTwice PragmaTwice merged commit dc4c249 into apache:unstable Aug 6, 2023
p1u3o pushed a commit to p1u3o/incubator-kvrocks that referenced this pull request Aug 15, 2023
@PragmaTwice @p1u3o
Make config enum error more clear for users (apache#1639)
45aaf0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaobiaozhao xiaobiaozhao xiaobiaozhao approved these changes

@mapleFU mapleFU mapleFU approved these changes

@enjoy-binbin enjoy-binbin enjoy-binbin approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PragmaTwice @git-hulk @enjoy-binbin @mapleFU @xiaobiaozhao