GEOSEARCH* from is not optional, FROMLONLAT or FROMMEMBER must require #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix that FROMLONLAT or FROMMEMBER is required, otherwise we would have the following inconsistency: ``` 127.0.0.1:6379> GEOSEARCH src BYBOX 88 88 m asc (error) ERR exactly one of FROMMEMBER or FROMLONLAT can be specified for GEOSEARCH 127.0.0.1:6379> GEOSEARCHSTORE dst src BYBOX 88 88 m asc (error) ERR exactly one of FROMMEMBER or FROMLONLAT can be specified for GEOSEARCHSTORE 127.0.0.1:6666> GEOSEARCH src BYBOX 88 88 m asc (empty array) 127.0.0.1:6666> GEOSEARCHSTORE dst src BYBOX 88 88 m asc (integer) 0 ``` Minor fix to minor bug.
torwig
approved these changes
Aug 9, 2023
p1u3o
pushed a commit
to p1u3o/incubator-kvrocks
that referenced
this pull request
Aug 15, 2023
apache#1656) Fix that FROMLONLAT or FROMMEMBER is required, otherwise we would have the following inconsistency: ``` 127.0.0.1:6379> GEOSEARCH src BYBOX 88 88 m asc (error) ERR exactly one of FROMMEMBER or FROMLONLAT can be specified for GEOSEARCH 127.0.0.1:6379> GEOSEARCHSTORE dst src BYBOX 88 88 m asc (error) ERR exactly one of FROMMEMBER or FROMLONLAT can be specified for GEOSEARCHSTORE 127.0.0.1:6666> GEOSEARCH src BYBOX 88 88 m asc (empty array) 127.0.0.1:6666> GEOSEARCHSTORE dst src BYBOX 88 88 m asc (integer) 0 ``` Minor fix to minor bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix that FROMLONLAT or FROMMEMBER is required, otherwise we would
have the following inconsistency:
Minor fix to minor bug.