Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several mismatching default option values and their comments #1664

Merged
merged 11 commits into from
Aug 11, 2023

Conversation

aleksraiden
Copy link
Contributor

In this PR:

  • rocksdb.max_open_files defaults setup to 8096, but in comment old value - 4096
  • Correct notice about max_write_buffer_number behavior (Misspelling, must be < 3, e.g.: If max_write_buffer_number < 3, writing will be slowed down to options.delayed_write_rate if we are writing to the last write buffer allowed.)
  • Fix max_sub_compactions describe
  • rocksdb.block_size defaults are 16384 or 16Kb, no 4 Kb (as in comment)
  • rocksdb.cache_index_and_filter_blocks defaults are yes instead of no in comment

Small fix in comments with default options
@PragmaTwice
Copy link
Member

Maybe you also need to update the default value in https://github.com/apache/kvrocks/blob/unstable/src/config/config.cc .

@aleksraiden
Copy link
Contributor Author

Maybe you also need to update the default value in https://github.com/apache/kvrocks/blob/unstable/src/config/config.cc .

You are right, done

caipengbo
caipengbo previously approved these changes Aug 11, 2023
kvrocks.conf Outdated Show resolved Hide resolved
@caipengbo caipengbo self-requested a review August 11, 2023 00:17
caipengbo
caipengbo previously approved these changes Aug 11, 2023
Copy link
Contributor

@caipengbo caipengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kvrocks.conf Show resolved Hide resolved
kvrocks.conf Show resolved Hide resolved
kvrocks.conf Show resolved Hide resolved
@torwig
Copy link
Contributor

torwig commented Aug 11, 2023

Wanted to cancel my comments but failed :)

mapleFU
mapleFU previously approved these changes Aug 11, 2023
Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Seems it doesn't change the default value because the conf file will overwrite the code default?

@aleksraiden aleksraiden dismissed stale reviews from mapleFU and caipengbo via 75aaa27 August 11, 2023 07:47
torwig
torwig previously approved these changes Aug 11, 2023
@aleksraiden
Copy link
Contributor Author

Thanks, @torwig for helps with config.cc

src/config/config.cc Outdated Show resolved Hide resolved
@aleksraiden aleksraiden requested a review from torwig August 11, 2023 12:11
caipengbo
caipengbo previously approved these changes Aug 11, 2023
src/config/config.cc Outdated Show resolved Hide resolved
@PragmaTwice PragmaTwice changed the title Small fix mismatching defaults options value and his comments Fix several mismatching default option values and his comments Aug 11, 2023
@PragmaTwice PragmaTwice changed the title Fix several mismatching default option values and his comments Fix several mismatching default option values and their comments Aug 11, 2023
@PragmaTwice PragmaTwice merged commit 56d5fbe into apache:unstable Aug 11, 2023
p1u3o pushed a commit to p1u3o/incubator-kvrocks that referenced this pull request Aug 15, 2023
@aleksraiden aleksraiden deleted the config-small-fix branch February 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants