-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several mismatching default option values and their comments #1664
Conversation
Small fix in comments with default options
Maybe you also need to update the default value in https://github.com/apache/kvrocks/blob/unstable/src/config/config.cc . |
You are right, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Wanted to cancel my comments but failed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Seems it doesn't change the default value because the conf file will overwrite the code default?
Thanks, @torwig for helps with config.cc |
In this PR: