-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the support of the LPOS command #1681
Conversation
i see we already have a pending #1571, what's the status over there? |
@enjoy-binbin That issue was assigned to another person by me (almost 2 months ago) and I think @JoverZhang just took the task and did it. |
Oh, Sorry, I don't know the status over there. Can I merge it? |
I guess it's fine since #1571 is lack active for more than one month, so it makes sense if others took over the task. |
@torwig Thank you for your review and feedback. I'll make the necessary changes. |
I did some stupid things with my GitHub App. |
@JoverZhang That's fine, you have done well in test coverage. You can choose to add the Go test cases only if conditions can be covered, and GoogleTest for which cannot be tested through the Go test. But now is good and you don't need to change anything. |
@git-hulk Thanks, I get it now. No wonder I also think there was duplicate coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
LGTM at first glance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Close #1528