-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LASTSAVE command #1702
Add LASTSAVE command #1702
Conversation
Hi @xq2010, thanks for your contribution. Could you please fix the issue in CI: https://github.com/apache/kvrocks/actions/runs/5974247406/job/16208064626#step:8:1361 |
Co-authored-by: Twice <twice@apache.org>
@xq2010 You need to modify the function signature not only in declaration but also in definition. |
The new implemention keeps consistent with Redis. But I think we need to fix the lint :-) |
Okay, I'll fix the lint and test error. |
thanks! |
@xq2010 The CI failed, and there are also conflicts against the unstable branch. You need to solve the conflict and fix the code to make CI pass. Sorry but currently I have no time to help you check the root cause. You can check the CI log or just run go test in your local. |
…save_time is changed to start_time_ at server startup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
add redis LASTSAVE command, modify the return value of info.persistence.rdb_last_save_time to be consistent with Redis, return start_time_ when bgsave is not performed.