Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LASTSAVE command #1702

Merged
merged 9 commits into from
Aug 28, 2023
Merged

Add LASTSAVE command #1702

merged 9 commits into from
Aug 28, 2023

Conversation

xq2010
Copy link
Contributor

@xq2010 xq2010 commented Aug 25, 2023

add redis LASTSAVE command, modify the return value of info.persistence.rdb_last_save_time to be consistent with Redis, return start_time_ when bgsave is not performed.

@git-hulk
Copy link
Member

Hi @xq2010, thanks for your contribution. Could you please fix the issue in CI: https://github.com/apache/kvrocks/actions/runs/5974247406/job/16208064626#step:8:1361

src/server/server.h Outdated Show resolved Hide resolved
@PragmaTwice
Copy link
Member

@xq2010 You need to modify the function signature not only in declaration but also in definition.

@mapleFU
Copy link
Member

mapleFU commented Aug 26, 2023

The new implemention keeps consistent with Redis. But I think we need to fix the lint :-)

src/server/server.cc Outdated Show resolved Hide resolved
@aleksraiden aleksraiden requested a review from torwig August 27, 2023 19:52
@xq2010
Copy link
Contributor Author

xq2010 commented Aug 28, 2023

The new implemention keeps consistent with Redis. But I think we need to fix the lint :-)↳

Okay, I'll fix the lint and test error.

@xq2010
Copy link
Contributor Author

xq2010 commented Aug 28, 2023

@xq2010 You need to modify the function signature not only in declaration but also in definition.↳

thanks!

@PragmaTwice
Copy link
Member

PragmaTwice commented Aug 28, 2023

@xq2010 The CI failed, and there are also conflicts against the unstable branch.

You need to solve the conflict and fix the code to make CI pass. Sorry but currently I have no time to help you check the root cause. You can check the CI log or just run go test in your local.

src/commands/cmd_server.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PragmaTwice PragmaTwice merged commit a64cabf into apache:unstable Aug 28, 2023
@xq2010 xq2010 deleted the feature/lastsave branch August 29, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants