Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resp functions instead of manual concatenation #1717

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

PragmaTwice
Copy link
Member

We need to remove all manual concatenation of reply to
make the code more maintainable.

@PragmaTwice PragmaTwice requested a review from git-hulk August 31, 2023 01:02
git-hulk
git-hulk previously approved these changes Aug 31, 2023
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PragmaTwice PragmaTwice changed the title Use reply function instead of manual concatenation Use resp functions instead of manual concatenation Aug 31, 2023
@PragmaTwice PragmaTwice merged commit e2baeb1 into apache:unstable Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants