Fix error messages in parsing of bit commands #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinze Wu <294843472@qq.com>
Signed-off-by: Jinze Wu <294843472@qq.com>
mapleFU
previously approved these changes
Sep 4, 2023
Signed-off-by: Jinze Wu <294843472@qq.com>
mapleFU
previously approved these changes
Sep 4, 2023
PragmaTwice
reviewed
Sep 4, 2023
PragmaTwice
reviewed
Sep 4, 2023
Signed-off-by: Jinze Wu <294843472@qq.com>
|
Will merge if all CI passed |
git-hulk
approved these changes
Sep 4, 2023
mapleFU
approved these changes
Sep 5, 2023
|
Thank you for catching this @gogim1 |
|
I want to complain about the PR title, which is not formal and clear enough to me. A better message may be "Fix error messages in parsing of bit commands". @mapleFU You can adjust the commit message before you merge it, please do not miss the chance. And please do not use spoken English and abbreviation, and avoid grammatical errors in command messages. |
gogim1
changed the title
|
Sorry for that, I'll wait for some time before merging. You can force push to overwrite the title @PragmaTwice |
|
It is forbidden by project settings to force push to the unstable branch. Just be careful next time : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the error message consistent with the error message in Redis when calling the bit commands.