Add the support of the BF.MEXISTS and BF.CARD Command #1756
Conversation
| @@ -40,6 +40,15 @@ std::string Integer(T data) { | |||
| return ":" + std::to_string(data) + CRLF; | |||
| } | |||
|
|
|||
| template <typename T, std::enable_if_t<std::is_integral_v<T>, int> = 0> | |||
| std::string MultiInteger(const std::vector<T> &multi_data) { | |||
There was a problem hiding this comment.
A quick question: would other Redis response can be help with MultiInteger?
There was a problem hiding this comment.
(Oh and @PragmaTwice and can we support a vector<bool> version to convert vector<bool> to 0/1 response?)
There was a problem hiding this comment.
not sure since resp3 supports boolean.
There was a problem hiding this comment.
It's seems only here(BF.MExists and BF.MAdd) and SMIsMember can be help with MultiInteger. Should we give up MultiInteger?
There was a problem hiding this comment.
You can put it in src/commands/cmd_bloom_filter.cc in anonymous namespace as a helper first. If you find any other user would use it, you can move it out.
There was a problem hiding this comment.
this function looks ok to me.
Co-authored-by: Twice <twice@apache.org>
This PR introduce the bloom BF.MEXISTS and BF.CARD command.
[1] https://redis.io/commands/bf.mexists/
[2] https://redis.io/commands/bf.card/