Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support of the BLMPOP command #1774

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Conversation

HolyLow
Copy link
Contributor

@HolyLow HolyLow commented Sep 22, 2023

This closes #1522.

This PR moves all the blocking-event related code to a upper class BlockedPopCommand, as all the blocking commands would share these utils.
If the BlockedPopCommand design gets accepted, I would try to refactor the other blocking commands, such as BLPOP, BRPOP and BLMOVE to reduce the code redundancy, just as commented by @git-hulk in previous discussion.

Any suggestions are welcomed.

@aleksraiden aleksraiden requested a review from torwig September 22, 2023 07:27
@PragmaTwice
Copy link
Member

PragmaTwice commented Sep 22, 2023

Hi @HolyLow , thank you for your contribution.

Could you consider to rewrite it in our new helper class BlockingCommander?

You can refer to CommandBPop for how to use it.

@PragmaTwice PragmaTwice changed the title Add the support of the BLMPOP command. Add the support of the BLMPOP command Sep 22, 2023
@HolyLow
Copy link
Contributor Author

HolyLow commented Sep 22, 2023

@PragmaTwice seems we've done the same thing separately... Sure, I would refactor the code. As the design is very similar, it wouldn't take long.

@HolyLow
Copy link
Contributor Author

HolyLow commented Sep 22, 2023

@PragmaTwice refactored to use BlockingCommander.

@HolyLow
Copy link
Contributor Author

HolyLow commented Sep 22, 2023

@PragmaTwice A CI test case failed with Ubuntu 20.04, clang, TLS on. The test case is in the tls_test (no command logic involved?), and I try my best to try to reproduce the problem on my local environment (Ubuntu22.04, clang-16, TLS on), but the error could not be reproduced...

I'm not aware what I should do now, could you please help?

@git-hulk
Copy link
Member

@PragmaTwice A CI test case failed with Ubuntu 20.04, clang, TLS on. The test case is in the tls_test (no command logic involved?), and I try my best to try to reproduce the problem on my local environment (Ubuntu22.04, clang-16, TLS on), but the error could not be reproduced...

I'm not aware what I should do now, could you please help?

It's a flaky test case, can ignore this failure for now. We're still investigating.

Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PragmaTwice PragmaTwice merged commit 711e41b into apache:unstable Sep 22, 2023
26 checks passed
@HolyLow HolyLow deleted the blmpop branch April 3, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the support of the BLMPOP command
4 participants