Add support of new command JSON.SET and JSON.GET #1803
Conversation
|
We can create an issue to track other new commands. And others can help to implement the new commands if they like. |
| jsoncons::json val; | ||
|
|
||
| try { | ||
| val = jsoncons::json::parse(str); |
There was a problem hiding this comment.
I think we'd better use parse with erroc version to avoid costing from the exception.
There was a problem hiding this comment.
It will be fixed in later PRs, or you can pick up it if you have free time : )
| jsoncons::jsonpath::json_replace(value, path, [&new_value](const std::string & /*path*/, jsoncons::json &origin) { | ||
| origin = std::move(new_value.value); | ||
| }); |
There was a problem hiding this comment.
Assume the path matches mutlple sub json object, this will be wrong
There was a problem hiding this comment.
I think since it follows preorder traversal so it will goes well when there are mutlple sub json objects matched in the original object.
But it will be wrong if there are json objects matched in the new_value, which will be fixed later.
There was a problem hiding this comment.
I don't think so, since new_value.value has been moved.
There was a problem hiding this comment.
Oh, good point. I will fix it.
|
Tests will be added in further PRs to make an example/reference for other issues in the tracking issue : ) |
We add support of two new commands
JSON.SETandJSON.GET(despite some options missing).Besides, we add two new methods
IsSingleKVTypeandIsEmptyableTypeto classMetadatafor more intuitive coding.JSON Metadata encoding:
The field
formatis to make JSON data type more extensible. Currently it can only be0to indicate that the data stored inpayloadis in the JSON format.TODO: