Fix server cannot start without the configuration file #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the server will load namespaces and rewrite when starting, and it may fail if the configuration file is not assigend. We should allow to start the server without the configuration file, but don't allow to modify namespaces if they're stored inside the configuration file.
PragmaTwice
approved these changes
Oct 15, 2023
torwig
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the server will load namespaces and rewrite when starting,
and it may fail if the configuration file is not assigned.
We should allow to start the server without the configuration file
but don't allow to modify namespaces if they're stored inside the configuration file.
Thanks for @PragmaTwice pointing out this error.