Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDB: fix Endian handling in rdb_intset #1830

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Oct 16, 2023

intrev16ifbe doesn't has any side-effect if no value is handled.

@mapleFU mapleFU requested a review from git-hulk October 16, 2023 06:54
@mapleFU mapleFU changed the title RDB: tiny fix be handling RDB: tiny fix Endian handling in rdb_intset Oct 16, 2023
git-hulk
git-hulk previously approved these changes Oct 16, 2023
@git-hulk
Copy link
Member

intrev64ifbe can be replaced with memrev64ifbe to keep consistent.

torwig
torwig previously approved these changes Oct 16, 2023
@mapleFU mapleFU dismissed stale reviews from torwig and git-hulk via 71d5859 October 16, 2023 07:17
@mapleFU
Copy link
Member Author

mapleFU commented Oct 16, 2023

intrev64ifbe can be replaced with memrev64ifbe to keep consistent.

Yeah it's a bug, just noticed and fixed that

Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mapleFU mapleFU changed the title RDB: tiny fix Endian handling in rdb_intset RDB: fix Endian handling in rdb_intset Oct 16, 2023
@mapleFU mapleFU merged commit 3e995df into apache:unstable Oct 16, 2023
28 checks passed
@mapleFU mapleFU deleted the tiny-fix branch October 16, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants