-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for JSON.STRAPPEND and JSON.STRLEN command #1841
Conversation
I fixed the problem you pointed out : ) |
4e91afb
to
0d119c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if you want to use -1
as a flag number, you DO NOT need to change unsigned integer type to signed integer. It is useless and make the situation more complicted.
If you don't get this point, you can refer to https://en.cppreference.com/w/cpp/string/basic_string/npos.
It also gonna be a blocking issue of this PR.
I understand |
Hi @guojidan, before we review this PR, you can first try to solve these conflicts with unstable. |
cc8d23f
to
5a11980
Compare
hi @PragmaTwice Thank you very much for your help, now I already rebase this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but it still has several issues which need to be addressed before merging.
756f193
to
8734ccc
Compare
1e85e8d
to
8e4d26e
Compare
Some places need to be improved, but I will do it in another PR:
To avoid PR being pending too long and those improvements are code style-related. So it's good for me to approve this PR first and improve it later. |
@guojidan Cloud you please resolve conflicts again |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This closes #1823 #1824