Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify server's shorten form, change svr to srv #1861

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

git-hulk
Copy link
Member

Currently, we have two shorten forms for the server variable name,
and it will be better to keep a consistent name.

Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a glance and seems that all modified variables is Server

@git-hulk
Copy link
Member Author

git-hulk commented Oct 30, 2023

Have a glance and seems that all modified variables is Server

Yes, only changed the variable name of server from svr to srv.

@mapleFU
Copy link
Member

mapleFU commented Oct 30, 2023

(I mean nothing weird is changed, aha )

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit 1962b86 into apache:unstable Oct 30, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants