Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support JSON.ARRINDEX command #1865

Merged
merged 2 commits into from
Nov 10, 2023
Merged

support JSON.ARRINDEX command #1865

merged 2 commits into from
Nov 10, 2023

Conversation

skyitachi
Copy link
Contributor

@skyitachi skyitachi marked this pull request as draft November 1, 2023 16:19
@skyitachi skyitachi marked this pull request as ready for review November 1, 2023 16:22
@torwig
Copy link
Contributor

torwig commented Nov 1, 2023

@skyitachi Thank you for your contribution. To avoid lint error during the CI, please run ./x.py format before the final commit and push.

@skyitachi
Copy link
Contributor Author

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 1 Code Smell

No Coverage information No Coverage information 4.9% 4.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

it seems no need to care about define const for JSON.ARRINDEX comman in json_test.go files ?

@PragmaTwice
Copy link
Member

Hi @skyitachi , currently you do not need to care about the sonarcloud report, since we have not finished its set-up yet.

But other CI checks (lint / build / unit tests) are mandatory.

PragmaTwice
PragmaTwice reviewed Nov 2, 2023
View reviewed changes
src/types/json.h Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice reviewed Nov 2, 2023
View reviewed changes
src/types/json.h Outdated Show resolved Hide resolved
@PragmaTwice
Copy link
Member

Seems the golangci-lint have failed. You can try to fix your golang code to make it pass.

https://github.com/apache/kvrocks/actions/runs/6734552602/job/18306093590?pr=1865

@skyitachi skyitachi force-pushed the arrindex branch 3 times, most recently from cd1e634 to 7aca04c Compare November 7, 2023 13:07
@PragmaTwice PragmaTwice requested a review from git-hulk November 8, 2023 15:43
git-hulk
git-hulk reviewed Nov 9, 2023
View reviewed changes
src/commands/cmd_json.cc Outdated Show resolved Hide resolved
git-hulk
git-hulk reviewed Nov 9, 2023
View reviewed changes
src/commands/cmd_json.cc Outdated Show resolved Hide resolved
git-hulk
git-hulk reviewed Nov 9, 2023
View reviewed changes
src/commands/cmd_json.cc Outdated Show resolved Hide resolved
git-hulk
git-hulk previously approved these changes Nov 9, 2023
View reviewed changes
@git-hulk
Copy link
Member

git-hulk commented Nov 9, 2023 •
edited
Loading

Hi @skyitachi Would you mind resolving conflicts before merging.

@git-hulk
Copy link
Member

git-hulk commented Nov 9, 2023

@skyitachi Seems previous suggestions are disappeared, can you apply them again?

@skyitachi
Copy link
Contributor Author

@skyitachi Seems previous suggestions are disappeared, can you apply them again?

ok, it's weired and I will apply code change again

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
4.6% 4.6% Duplication

@git-hulk git-hulk merged commit 319de1e into apache:unstable Nov 10, 2023
30 checks passed
@jihuayu jihuayu mentioned this pull request Nov 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice left review comments

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skyitachi @torwig @PragmaTwice @git-hulk