Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for the JSON.ARRINSERT command #1867

Merged
merged 18 commits into from
Nov 17, 2023
Merged

Support for the JSON.ARRINSERT command #1867

merged 18 commits into from
Nov 17, 2023

Conversation

jihuayu
Copy link
Member

@jihuayu jihuayu commented Nov 2, 2023

@git-hulk git-hulk requested a review from PragmaTwice November 3, 2023 05:31
@git-hulk
Copy link
Member

git-hulk commented Nov 3, 2023

Looks generally good to me, thank you!

@jihuayu
Copy link
Member Author

jihuayu commented Nov 3, 2023

The logic for when index > array size is missing here. I need to first check the behavior of the Redis stack in this situation.

@jihuayu
Copy link
Member Author

jihuayu commented Nov 3, 2023

😿 😿 😿
RedisJSON/RedisJSON#1129
RedisJSON's json.arrinsert has some bugs. We need to wait for the upstream to determine the correct logic.

@mapleFU
Copy link
Member

mapleFU commented Nov 3, 2023

We don't need to follow it ( but I guess mention it in comment is better)

@jihuayu jihuayu marked this pull request as ready for review November 12, 2023 10:21
git-hulk
git-hulk previously approved these changes Nov 17, 2023
View reviewed changes
src/types/json.h Outdated Show resolved Hide resolved
@git-hulk
Copy link
Member

git-hulk commented Nov 17, 2023 •
edited
Loading

Only one typo in the comment inline, rest are good to me.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
7.6% 7.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@git-hulk git-hulk merged commit 2cab8f7 into apache:unstable Nov 17, 2023
29 of 30 checks passed
@jihuayu jihuayu deleted the issues/1080 branch November 18, 2023 00:43
@jihuayu jihuayu mentioned this pull request Nov 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jihuayu @git-hulk @mapleFU