Add CBOR as a storage format for the JSON data type #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
wow, that's cool |
git-hulk
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, CBOR is used as a storage format alternative (written to/read from hard drive) for the JSON data type (RedisJSON).
CBOR (RFC 8949) is a binary data format compatible to the JSON data model, hence it has more efficient encoding/decoding performance and more compact data size.
From my observation and simple benchmarking, using CBOR instead of JSON as a storage format and JSON document testing datasets from RedisJSON, kvrocks speed up its performance of
JSON.GETandJSON.SETby ~5%, and its storage usage is reduced by more than 10%.NOTE: The default storage format of JSON data type is still JSON.