Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for the JSON.TOGGLE command #1875

Merged
merged 20 commits into from
Nov 9, 2023
Merged

support for the JSON.TOGGLE command #1875

merged 20 commits into from
Nov 9, 2023

Conversation

MaheshMadushan
Copy link
Contributor

@MaheshMadushan MaheshMadushan commented Nov 3, 2023 •
edited
Loading

[Add support for the JSON.TOGGLE command #1825]

PragmaTwice
PragmaTwice reviewed Nov 3, 2023
View reviewed changes
src/types/json.h Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice reviewed Nov 3, 2023
View reviewed changes
src/types/json.h Outdated Show resolved Hide resolved
MaheshMadushan and others added 2 commits November 4, 2023 08:35
PragmaTwice
PragmaTwice previously approved these changes Nov 4, 2023
View reviewed changes
@PragmaTwice
Copy link
Member

You can try to build it to make sure it will pass the compiler before pushing.

@MaheshMadushan
Copy link
Contributor Author

You can try to build it to make sure it will pass the compiler before pushing.

issue fixed.

git-hulk
git-hulk reviewed Nov 4, 2023
View reviewed changes
src/types/json.h Outdated Show resolved Hide resolved
@MaheshMadushan
JSON.TOGGLE returns an array of integer replies for each path, the ne…
4940a9f 
…w value (0 if false or 1 if true), or nil for JSON values matching the path that are not Boolean.

JSON TOGGLE ouput fix

JSON>TOGGLE output fixed

Update cmd_json.cc
PragmaTwice
PragmaTwice reviewed Nov 5, 2023
View reviewed changes
src/types/json.h Outdated Show resolved Hide resolved
MaheshMadushan and others added 2 commits November 9, 2023 09:19
@MaheshMadushan
review comment addresed
47d100e 
issue fix and go test cases fixes

issue fix and go test cases fixes
@git-hulk
Merge branch 'unstable' into unstable
287b14d
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

git-hulk
git-hulk approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@MaheshMadushan
Copy link
Contributor Author

LGTM, thanks

Thanks for the feedback

@git-hulk git-hulk merged commit 1083142 into apache:unstable Nov 9, 2023
30 checks passed
@git-hulk
Copy link
Member

git-hulk commented Nov 9, 2023

@MaheshMadushan Thanks for your contribution.

@jihuayu jihuayu mentioned this pull request Nov 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice left review comments

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaheshMadushan @PragmaTwice @git-hulk