Fix potentially overflow msg_namelen value in SupervisedSystemd

[PragmaTwice]

kvrocks/src/cli/daemon_util.h

Line 75 in 78f87c4

hdr.msg_namelen = offsetof(struct sockaddr_un, sun_path) + strlen(notify_socket);

The value of msg_namelen may cause potentially overflow since notify_socket is not the real truncated one. So we need to use strlen(notify_socket) instead of strlen(su.sun_path).

Besides, some other code has been cleaned up.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
1 Security Hotspot
0 Code Smells

No Coverage information
1.7% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[git-hulk]

@PragmaTwice Sonar Lint reports hotspot security due to using the stren function in daemon_util.h, but I guess it should be fine since the variable is always set the \0.

[PragmaTwice]

@PragmaTwice Sonar Lint reports hotspot security due to using the stren function in daemon_util.h, but I guess it should be fine since the variable is always set the \0.

This strlen is not introduced by me lol.

[git-hulk]

@PragmaTwice Sonar Lint reports hotspot security due to using the stren function in daemon_util.h, but I guess it should be fine since the variable is always set the \0.

This strlen is not introduced by me lol.

aha, yes i know. What I mean is to ignore this hotspot security report.