Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix go test JSON.TOGGLE basics parameters order #1892

Merged
merged 2 commits into from
Nov 12, 2023
Merged

fix go test JSON.TOGGLE basics parameters order #1892

merged 2 commits into from
Nov 12, 2023

Conversation

jihuayu
Copy link
Member

@jihuayu jihuayu commented Nov 12, 2023

The PR has been fixed in the JSON.TOGGLE basics test case, where the parameters order of the require.Equal function was incorrect.

torwig
torwig approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihuayu Good catch.
LGTM if there are no lint issues.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.9% 11.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@git-hulk git-hulk merged commit 21f7997 into apache:unstable Nov 12, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jihuayu @git-hulk @torwig