Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of the command RENAME&RENAMENX #2026

Merged
merged 13 commits into from
Jan 23, 2024
Merged

Add support of the command RENAME&RENAMENX #2026

merged 13 commits into from
Jan 23, 2024

Conversation

jihuayu
Copy link
Member

@jihuayu jihuayu commented Jan 17, 2024

close #1951

jihuayu
jihuayu commented Jan 17, 2024
View reviewed changes
src/storage/redis_db.cc Outdated Show resolved Hide resolved
src/storage/redis_db.cc Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

11 New issues
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

git-hulk
git-hulk reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

My only suggestion is to add a comment line to explain why we need to do another write operation for ZSET.

Thanks for your nice test suites for the RENAME command.

src/storage/redis_db.cc Show resolved Hide resolved
@git-hulk git-hulk requested a review from torwig January 23, 2024 05:09
@jihuayu @git-hulk
Update src/storage/redis_db.cc
fa2b6ff 
Co-authored-by: hulk <hulk.website@gmail.com>
@git-hulk git-hulk merged commit 0f104e5 into apache:unstable Jan 23, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support of the command RENAMENX
3 participants
@jihuayu @git-hulk @torwig