Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine ctor definition of CommandParser #2044

Merged
merged 10 commits into from
Jan 26, 2024
Merged

Refine ctor definition of CommandParser #2044

merged 10 commits into from
Jan 26, 2024

Conversation

PragmaTwice
Copy link
Member

See changes.

@PragmaTwice PragmaTwice requested a review from git-hulk January 22, 2024 15:18
torwig
torwig previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter doesn't like where && was placed.

@PragmaTwice PragmaTwice marked this pull request as ready for review January 23, 2024 12:05
git-hulk
git-hulk previously approved these changes Jan 24, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
60.6% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarCloud

@git-hulk git-hulk merged commit 4bb6954 into apache:unstable Jan 26, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @torwig