Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonar action can't get PR number #2048

Merged
merged 8 commits into from
Jan 25, 2024
Merged

Conversation

jihuayu
Copy link
Member

@jihuayu jihuayu commented Jan 24, 2024

We only save PR info in the CI action pull_request event.

It was tested under https://github.com/jihuayu/kvrocks-test

Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your great efforts.

.github/workflows/kvrocks.yaml Outdated Show resolved Hide resolved
jihuayu and others added 2 commits January 25, 2024 16:21
Co-authored-by: hulk <hulk.website@gmail.com>
@PragmaTwice PragmaTwice merged commit 8361174 into apache:unstable Jan 25, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants