Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: BITCOUNT/BITPOS negative handling fixing #2069

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Bugfix: BITCOUNT/BITPOS negative handling fixing #2069

merged 9 commits into from
Jan 29, 2024

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Jan 28, 2024 •
edited
Loading

Fixing and testing BITCOUNT with negative start/stop.

This patch:

  1. Add a BitmapString::NormalizeRange for handling the range
  2. For BITCOUNT/BITPOS, fixing the syntax of value.size()
  3. Add the testing

@mapleFU mapleFU marked this pull request as ready for review January 28, 2024 15:21
@mapleFU
Copy link
Member Author

mapleFU commented Jan 28, 2024

@git-hulk @PragmaTwice

cc @kay011

@mapleFU mapleFU changed the title Bugfix: BITCOUNT negative handling fixing Bugfix: BITCOUNT/BITPOS negative handling fixing Jan 28, 2024
@mapleFU mapleFU mentioned this pull request Jan 28, 2024
Closed
2 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 28, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
60.2% Coverage on New Code
1.5% Duplication on New Code

See analysis details on SonarCloud

jihuayu
jihuayu reviewed Jan 29, 2024
View reviewed changes
src/types/redis_bitmap.cc Outdated Show resolved Hide resolved
@PragmaTwice PragmaTwice merged commit aa1de3f into apache:unstable Jan 29, 2024
29 checks passed
@mapleFU mapleFU deleted the bitcount-fixing-boundary branch January 29, 2024 12:32
JoverZhang pushed a commit to JoverZhang/kvrocks that referenced this pull request Feb 24, 2024
@mapleFU @JoverZhang
Fix BITCOUNT/BITPOS negative handling (apache#2069)
d0034f4 
Fixing and testing BITCOUNT with negative start/stop.

This patch:
1. Add a `BitmapString::NormalizeRange` for handling the range
2. For BITCOUNT/BITPOS, fixing the syntax of `value.size()`
3. Add the testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihuayu jihuayu jihuayu left review comments

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@git-hulk git-hulk Awaiting requested review from git-hulk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mapleFU @PragmaTwice @jihuayu