Make BITPOS in Bitmap handling stop_given
#2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapleFU
commented
Feb 1, 2024
| } | ||
| bitmap_->BitPos(key_, false, 0, 0, /*stop_given=*/true, &pos); | ||
| EXPECT_EQ(-1, pos); | ||
| bitmap_->BitPos(key_, false, 0, 1, /*stop_given=*/false, &pos); |
There was a problem hiding this comment.
If test:
bitmap_->BitPos(key_, false, 0, 1, /*stop_given=*/false, &pos);
The result is undefined, sigh...
mapleFU
commented
Feb 1, 2024
| @@ -285,6 +285,10 @@ rocksdb::Status Bitmap::BitPos(const Slice &user_key, bool bit, int64_t start, i | |||
| std::tie(start, stop) = BitmapString::NormalizeRange(start, stop, static_cast<int64_t>(metadata.size)); | |||
| auto u_start = static_cast<uint32_t>(start); | |||
| auto u_stop = static_cast<uint32_t>(stop); | |||
| if (u_start > u_stop) { | |||
There was a problem hiding this comment.
This unifying the responds of BitmapString
mapleFU
commented
Feb 1, 2024
| } | ||
| // There're two cases that `pin_value.size() < kBitmapSegmentBytes`: | ||
| // 1. If it's the last segment, we've done searching in the above loop. | ||
| // 2. If it's not the last segment, we can check if the segment is all 0. |
There was a problem hiding this comment.
The logic here is a bit hacking:
- if
bit, we don't search the value greater than searching area - if
i == stop_index, making the logic outside the loop to decide the response - Otherwise, searching setting the
pos
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2084