Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use require.JSONEq instead of require.Equal for the JSON string #2100

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Use require.JSONEq instead of require.Equal for the JSON string #2100

merged 4 commits into from
Feb 13, 2024

Conversation

jihuayu
Copy link
Member

@jihuayu jihuayu commented Feb 13, 2024

I have used require.JSONEq instead of require.Equal for the JSON string.
We don't need to test the order of the elements in the JSON.

git-hulk
git-hulk previously approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

tisonkun
tisonkun previously approved these changes Feb 13, 2024
View reviewed changes
PragmaTwice
PragmaTwice requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@PragmaTwice PragmaTwice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least in some test cases, we need to validate the indent and spaces of the output JSON. And JSONEq will just ignore all of them.

For exmaple, all cases in JSON.GET with options.

@jihuayu jihuayu dismissed stale reviews from tisonkun and git-hulk via b84b771 February 13, 2024 08:29
@jihuayu
Copy link
Member Author

jihuayu commented Feb 13, 2024

At least in some test cases, we need to validate the indent and spaces of the output JSON. And JSONEq will just ignore all of them.

For exmaple, all cases in JSON.GET with options.

Thank you, I fixed it.

@jihuayu jihuayu requested a review from PragmaTwice February 13, 2024 09:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
66.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tisonkun tisonkun merged commit cf2f4ad into apache:unstable Feb 13, 2024
30 checks passed
JoverZhang pushed a commit to JoverZhang/kvrocks that referenced this pull request Feb 24, 2024
@jihuayu @git-hulk @JoverZhang
test: Use require.JSONEq instead of require.Equal for the JSON string (…
87ebc63 
…apache#2100)

Co-authored-by: hulk <hulk.website@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@tisonkun tisonkun tisonkun left review comments

@git-hulk git-hulk git-hulk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jihuayu @git-hulk @tisonkun @PragmaTwice