Add support of RESP3 verbatim string

[wsehjk]

This pr is to close #2036.

[wsehjk]

This implementation refers other RESPV3 type support, I'm really not sure whether it works. Plz review my code. Thanks

[git-hulk]

@wsehjk You can search addReplyVerbatim inside Redis codebase to see where's using the verbatim string and also replace it in Kvrocks.

[PragmaTwice]

Repeated comment deleted.

[wsehjk]

https://github.com/wsehjk/kvrocks/actions/runs/7932113585. CI has passed

[wsehjk]

Code updated.

[PragmaTwice]

@wsehjk You can search addReplyVerbatim inside Redis codebase to see where's using the verbatim string and also replace it in Kvrocks.

@wsehjk As mentioned by @git-hulk , besides adding the reply function, we need to replace it in existing command impls.

[wsehjk]

@wsehjk You can search addReplyVerbatim inside Redis codebase to see where's using the verbatim string and also replace it in Kvrocks.

@wsehjk As mentioned by @git-hulk , besides adding the reply function, we need to replace it in existing command impls.

Well, I figure out what you mean, wan't ware of this additional work before. I will work on this. But can we do this in a seperate issue and merge this pr #2102?

[git-hulk]

@wsehjk After taking a look at addReplyVerbatim, only one place that needs to be changed in Kvrocks: use verbatim string while replying to the cluster command: https://github.com/redis/redis/blob/c854873746e9515f322d805f863e839ebfcefd62/src/cluster.c#L853

And for the Lua part, I will do it in the next PR.

[wsehjk]

@wsehjk After taking a look at addReplyVerbatim, only one place that needs to be changed in Kvrocks: use verbatim string while replying to the cluster command: https://github.com/redis/redis/blob/c854873746e9515f322d805f863e839ebfcefd62/src/cluster.c#L853

And for the Lua part, I will do it in the next PR.

what about the info cmd and client cmd https://github.com/redis/redis/blob/c854873746e9515f322d805f863e839ebfcefd62/src/server.c#L6082
https://github.com/redis/redis/blob/c854873746e9515f322d805f863e839ebfcefd62/src/networking.c#L3086

[git-hulk]

@wsehjk After taking a look at addReplyVerbatim, only one place that needs to be changed in Kvrocks: use verbatim string while replying to the cluster command: https://github.com/redis/redis/blob/c854873746e9515f322d805f863e839ebfcefd62/src/cluster.c#L853
And for the Lua part, I will do it in the next PR.

what about the info cmd and client cmd https://github.com/redis/redis/blob/c854873746e9515f322d805f863e839ebfcefd62/src/server.c#L6082 https://github.com/redis/redis/blob/c854873746e9515f322d805f863e839ebfcefd62/src/networking.c#L3086

Yes, can fix them as well.

[wsehjk]

As discussed before, I replace redis::BulkString with connection->VerbatimString()reply in info, client and clustercommand where in redis codebae addReplyVerbatim reply is used

[sonarcloud]

Quality Gate failed

Failed conditions
51.5% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

[wsehjk]

Thanks

[git-hulk]

@wsehjk Thanks for your contributions!