Fix XREADGROUP command didn't fetch the latest metadata after creating a consumer #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
changed the title
torwig
approved these changes
Mar 11, 2024
|
PragmaTwice
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function RangeWithPending needs to fetch the newset data of consumer group metadata, or it will exist a bug.
For example, a consumer group is empty with no consumer and function RangeWithPending will create a consumer for it when necessary. But we've fetched the group's metadata before creating the consumer, if we don't get the newest data the group metadata we write later will be wrong. The prefetched data's consumer number is 0, the newest data's consumer number is 1, we'll write 0 back if we don't fetch the newest data which leads to a wrong number of consumer.