-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of the command MOVEX #2225
Conversation
Hi @Chiro11, thanks for your PR. |
You mean to use a new name? Do you have any idea? |
Yes. @git-hulk @PragmaTwice @mapleFU @enjoy-binbin Do you have some idea about new command name? |
Perhaps MOVEX is a good name for aligning with the CLUSTERX command. |
|
@Chiro11 Thanks for your efforts and quick response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your code. @Chiro11
This PR contains a lot of refactoring unrelated to the movex
command. Could you please move it to a new PR?
Rest are good to me, one comment inline. |
I think here the |
The point of @PragmaTwice is we can find the |
I know. But I think |
@Chiro11 So let's remove it if you feel good about this. |
|
Thanks @Chiro11. Good job! Can you add this command to our website? If you're willing, can you work for #2229? |
Close #1950
Some desc:
MOVE key db
is treated as dummy command, to be compatible with Redis.MOVEX key ns_token
moves a key to new namespace.requirepass
is empty, report an error.