Optimize the implementation of IntervalSet intersection #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
13015517713
commented
May 7, 2024
13015517713
commented
- Optimize the implementation of IntervalSet intersection
- add some unittest for IntervalSet &(op)
|
related issue: #2295 |
|
|
done |
|
Format problems occurs frequently, let me create an extra issue for that: #2301 |
|
Use rand() function in unit testing. That check could be ignored, I guees. |
mapleFU
reviewed
May 8, 2024
| auto it_r = r.intervals.begin(); | ||
|
|
||
| while (it_l != l.intervals.end() && it_r != r.intervals.end()) { | ||
| // Find overlap between current intervals |
There was a problem hiding this comment.
@PragmaTwice quick question, does our interval prevent from generating qNaN?
There was a problem hiding this comment.
We assume that there's no NaN in the input.
PragmaTwice
reviewed
May 8, 2024
.gitignore
Outdated
| @@ -46,3 +46,4 @@ testdb | |||
|
|
|||
| build | |||
| cmake-build-* | |||
| unittest | |||
There was a problem hiding this comment.
Hmm seems not necessary to be added into gitignore?
PragmaTwice
reviewed
May 8, 2024
src/search/interval.h
Outdated
| double end = std::min(it_l->second, it_r->second); | ||
|
|
||
| if (start <= end) { | ||
| result.intervals.push_back(std::make_pair(start, end)); |
There was a problem hiding this comment.
Suggested change
| result.intervals.push_back(std::make_pair(start, end)); | |
| result.intervals.emplace_back(start, end); |
2.Change rand() to std::rand() and remove the header stdlib.h
PragmaTwice
approved these changes
May 9, 2024
mapleFU
approved these changes
May 9, 2024
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.