Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging message for retryable background IO errors #2317

Merged
merged 7 commits into from
May 17, 2024
+6 −2
Merged

Improve logging message for retryable background IO errors #2317

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c035675
improve logging message for retryableIOErrors
VasuDevrani May 16, 2024
f715076
Update src/server/server.cc
VasuDevrani May 16, 2024
c695aa5
Update src/server/server.cc
PragmaTwice May 16, 2024
ddd7771
Update src/server/server.cc
PragmaTwice May 16, 2024
e9346f0
Update src/server/server.cc
caipengbo May 16, 2024
2193497
Update src/server/server.cc
caipengbo May 16, 2024
ccaf7e6
Update src/server/server.cc
VasuDevrani May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/server/server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,9 +808,13 @@ void Server::cron() {
// In order to properly handle all possible situations on rocksdb, we manually resume here
// when encountering no space error and disk quota exceeded error.
if (counter != 0 && counter % 600 == 0 && storage->IsDBInRetryableIOError()) {
storage->GetDB()->Resume();
LOG(INFO) << "[server] Schedule to resume DB after retryable IO error";
storage->SetDBInRetryableIOError(false);
rocksdb::Status status = storage->GetDB()->Resume();
PragmaTwice marked this conversation as resolved.
Show resolved Hide resolved
if (status.ok()) {
caipengbo marked this conversation as resolved.
Show resolved Hide resolved
LOG(WARNING) << "[server] Successfully resumed DB after retryable IO error.";
PragmaTwice marked this conversation as resolved.
Show resolved Hide resolved
storage->SetDBInRetryableIOError(false);
} else {
LOG(ERROR) << "[server] Failed to resume DB after retryable IO error: " << status.ToString();
caipengbo marked this conversation as resolved.
Show resolved Hide resolved
}
}

// check if we need to clean up exited worker threads every 5s
Expand Down