Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pr-lint): force the PR title to follow the conventional commits #2342

Merged
merged 4 commits into from
May 31, 2024

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented May 30, 2024

@PragmaTwice PragmaTwice requested a review from git-hulk May 30, 2024 10:56
@git-hulk
Copy link
Member

cc @apache/kvrocks-committers

Copy link
Member

@enjoy-binbin enjoy-binbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the title must contain these keywords?

          types: |
            fix
            feat
            build
            chore
            ci
            docs
            perf
            refactor
            revert
            style
            test

and the title will become fix: xxx feat: xxx chore: xxx something like this? i must say i am not a fan of these keywords personally, but ok

@PragmaTwice
Copy link
Member Author

PragmaTwice commented May 30, 2024

so the title must contain these keywords?

          types: |
            fix
            feat
            build
            chore
            ci
            docs
            perf
            refactor
            revert
            style
            test

and the title will become fix: xxx feat: xxx chore: xxx something like this? i must say i am not a fan of these keywords personally, but ok

It's basically type(scope): subject, but scope can be omitted. e.g.

  • fix(#xxx): remove the wrong xxx
  • feat(search): add encoding for vector field
  • ci: remove the macos workflow

Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@PragmaTwice PragmaTwice merged commit c750a16 into apache:unstable May 31, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants