Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: git hook pre-push #2359

Merged
merged 12 commits into from
Jun 14, 2024
Merged

feat: git hook pre-push #2359

merged 12 commits into from
Jun 14, 2024

Conversation

PokIsemaine
Copy link
Contributor

fix: #2301

@PokIsemaine PokIsemaine marked this pull request as draft June 9, 2024 08:16
@PokIsemaine PokIsemaine marked this pull request as ready for review June 9, 2024 08:22
pre-push.sh Outdated Show resolved Hide resolved
x.py Outdated Show resolved Hide resolved
x.py Show resolved Hide resolved
@PokIsemaine PokIsemaine marked this pull request as draft June 9, 2024 11:19
@PokIsemaine PokIsemaine marked this pull request as ready for review June 10, 2024 12:11
@tisonkun
Copy link
Member

add-git-hooks sounds wordy and too specific to use. Follwoing npm's practice that uses git hook heavily, we can add a prepare target in x.py. No need for disable and list, that looks strange ...

@PokIsemaine
Copy link
Contributor Author

add-git-hooks sounds wordy and too specific to use. Follwoing npm's practice that uses git hook heavily, we can add a prepare target in x.py. No need for disable and list, that looks strange .. .

How to trigger prepare? Triggered as a separate subcommand or when x.py build?
In addition to git hooks, will prepare have other actions in the future?

I'm okay with both, @PragmaTwice do you have any suggestions?

@PragmaTwice
Copy link
Member

Sounds good to me. We can just have a ./x.py prepare.

x.py Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice previously approved these changes Jun 13, 2024
x.py Outdated Show resolved Hide resolved
x.py Outdated Show resolved Hide resolved
@PokIsemaine PokIsemaine marked this pull request as draft June 14, 2024 03:34
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as ready for review June 14, 2024 04:29
Copy link

@tisonkun tisonkun merged commit 84a3559 into apache:unstable Jun 14, 2024
33 checks passed
@tisonkun
Copy link
Member

Thanks for your contribution @PokIsemaine!

@PokIsemaine PokIsemaine deleted the git-hook branch June 14, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tools] Add a git commit hook for clang-format checking
4 participants