-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use official typos github action #2388
Conversation
@shoothzj Thanks for your contribution. Seems the configuration file didn't take effect. |
@git-hulk Thanks for your quick reply, I will figure out it why :) |
@git-hulk Why do you think configuration not works? I guess ci is failed because I bump the typos-check version also, I can also fix new typos in this PR. I debug this actions in my fork repo. It seems paas dir successfully. https://github.com/shoothzj/kvrocks/actions/runs/9732469130/job/26858166901
|
@shoothzj Thanks for your investigation. I found those typos weren't found before, so I'm wondering if the configuration wasn't set correctly before this PR. But maybe I was wrong since it uses different versions of typos. |
This is the reason. Typos update its vocabulary about each month. |
We can rename |
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
@git-hulk @PragmaTwice I downgraded the version, I think we can merge this first. As for |
Quality Gate passedIssues Measures |
Thanks for your contribution! |
create-ci/typos
is whitelisted in https://issues.apache.org/jira/browse/INFRA-25798. I propose to switch, using official github actions will have better interactions in github PR.