-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add iter->status()
check for loop iterators
#2395
feat: add iter->status()
check for loop iterators
#2395
Conversation
iter->status()
check for loop iteratorsiter->status()
check for loop iterators
043e916
to
f887cfc
Compare
LGTM, one comment inline. |
Hi @git-hulk , I find it seems hard to create unit tests for the error handling code and pass sonarcloud coverage. Best Regards, |
@LindaSummer That’s fine for this PR, no need to add the extra tests. |
Quality Gate failedFailed conditions |
Hi @git-hulk , Got it! 😊 Best Regards, |
Issue
close #2200
Proposed Changes
Comment
Valid()
after loop so I didn't add status validation.Here is rocksdb's document.
Thanks very much!